Review Request 124186: [runtime] Install headers and library for the private part

[Martin Gräßlin]

> On June 26, 2015, 7:05 p.m., Hrvoje Senjan wrote:
> > src/runtime/CMakeLists.txt, line 26
> > <https://git.reviewboard.kde.org/r/124186/diff/1/?file=381423#file381423line26>
> >
> >     I can't say what's more correct, as this would be a precedent for installing private headers, maybe  maybe going Qt way would be more consistent? ($module/$version/$module)

please also see https://mail.kde.org/pipermail/kde-frameworks-devel/2015-June/025046.html

I went now for the way Aleix prefers (as he was the only one participating) to make it a stable variant. It only uses the name "private" here to indicate that it's not API intended to be used by applications. Otherwise it follows the same ABI stability requirements as all of frameworks.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124186/#review81783
-----------------------------------------------------------


On June 26, 2015, 1:51 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124186/
> -----------------------------------------------------------
> 
> (Updated June 26, 2015, 1:51 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> We need to make the library and plugin interface available to support
> more platforms. On a Plasma Wayland session it's required that KWin
> becomes KGlobalAccel. KWin is the only process which can filter key
> events and for security reasons KWin will not delegate them to other
> applications.
> 
> This means KWin needs to create KGlobalAccelD before KWin or any other
> process tries to register a global shortcuts triggering kglobalaccel5
> to be started.
> 
> In addition KWin needs to provide it's own plugin which it can interact
> with.
> 
> 
> Diffs
> -----
> 
>   src/runtime/CMakeLists.txt 248762f98a6d5b24d4298976bdd1b5a1b4cf1a2c 
> 
> Diff: https://git.reviewboard.kde.org/r/124186/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150626/399b8e31/attachment.html>