Review Request 124155: Add KStatusNotifierItem::action(const QString &) to retrieve an action by name

[Alexander Potashev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124155/#review81741
-----------------------------------------------------------


Nothing "criminal" I could see here. Side note: I guess action names could be QLatin1Strings, not QStrings, may be we should change this in KF6.

- Alexander Potashev


On June 23, 2015, 12:04 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124155/
> -----------------------------------------------------------
> 
> (Updated June 23, 2015, 12:04 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 349513
>     https://bugs.kde.org/show_bug.cgi?id=349513
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> Apparently this got removed while porting; the code allows to set custom action by name and remove too, no reason why it shouldn't allow retrieving it by the name.
> 
> 
> Diffs
> -----
> 
>   src/kstatusnotifieritem.h 04102d1 
>   src/kstatusnotifieritem.cpp 4fd2fda 
> 
> Diff: https://git.reviewboard.kde.org/r/124155/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150625/4048e5df/attachment.html>