Review Request 124104: Make it possible to use kconfig_compiler from different sources

[Aleix Pol Gonzalez]

> On June 24, 2015, 9:17 p.m., Alex Merry wrote:
> > src/kconfig_compiler/CMakeLists.txt, line 13
> > <https://git.reviewboard.kde.org/r/124104/diff/2/?file=380381#file380381line13>
> >
> >     A bit late to the party, sorry, but this would be better as message(WARNING "...").

You're right. I'll add it anyway. Thanks!


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124104/#review81729
-----------------------------------------------------------


On June 21, 2015, 2:16 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124104/
> -----------------------------------------------------------
> 
> (Updated June 21, 2015, 2:16 a.m.)
> 
> 
> Review request for Build System, KDE Frameworks, Matthew Dawson, and Harald Sitter.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Separates the tooling that is supposed to be used at run-time so that we can specify which to use explicitly.
> 
> Ideally this would be done automagically, for now we'll have to specify -DKF5ConfigCompiler_DIR=...
> 
> Additionally, we should make kconfig_compiler co-installable by putting it in libexec, but I'd prefer to do that in a future patch. This same process should also happen on other frameworks.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f510e3e 
>   KF5ConfigConfig.cmake.in b4e5f56 
>   src/kconfig_compiler/CMakeLists.txt ec4a733 
> 
> Diff: https://git.reviewboard.kde.org/r/124104/diff/
> 
> 
> Testing
> -------
> 
> Works as expected on my debian chroot environment.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150624/f4d85b00/attachment-0001.html>