Review Request 124165: Make KArchive preserve permissions from the files inside the archive
Romário Rios
luizromario at gmail.com
Wed Jun 24 17:00:44 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124165/
-----------------------------------------------------------
(Updated June 24, 2015, 5 p.m.)
Review request for KDE Frameworks.
Repository: karchive
Description
-------
The KArchiveFile::copyTo() wasn't setting the permissions of the files it copied -- it just copied the data. So, for instance, if an archive contained an executable, it was extracted from the archive as a non-executable. This patch makes it apply the permission information found in the KArchiveFile to the QFile being copied.
Diffs
-----
src/karchive.cpp 344cba8
Diff: https://git.reviewboard.kde.org/r/124165/diff/
Testing
-------
Seems to work for all files (tested with xz and zip files containing executables, directories, text, etc.).
Thanks,
Romário Rios
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150624/3a9a7db7/attachment.html>
More information about the Kde-frameworks-devel
mailing list