Review Request 124143: Implement PersonsModel filtering facilities
Martin Klapetek
martin.klapetek at gmail.com
Wed Jun 24 11:51:29 UTC 2015
> On June 21, 2015, 8:50 p.m., Aleix Pol Gonzalez wrote:
> > I'm not very fond of the customProperty().isNull method, maybe it would make sense to add a ::ProvidedKeys field we can use. Any thoughts?
Yeah, seems that would be better (::ProvidedProperties).
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124143/#review81630
-----------------------------------------------------------
On June 22, 2015, 7:47 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124143/
> -----------------------------------------------------------
>
> (Updated June 22, 2015, 7:47 a.m.)
>
>
> Review request for KDE Frameworks, KDEPIM and Martin Klapetek.
>
>
> Repository: kpeople
>
>
> Description
> -------
>
> Makes it possible to filter the model by the offered properties.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt e050b8d
> src/backends/abstractcontact.h 69e6b6d
> src/backends/abstractcontact.cpp f5cd452
> src/personssortfilterproxymodel.h PRE-CREATION
> src/personssortfilterproxymodel.cpp PRE-CREATION
> autotests/CMakeLists.txt ece7e60
> autotests/fakecontactsource.h 53f1ef2
> autotests/fakecontactsource.cpp 2e12c2d
> autotests/persondatatests.cpp f752e5d
> autotests/personsmodeltest.cpp 8a467ef
> autotests/personsproxymodeltest.h PRE-CREATION
> autotests/personsproxymodeltest.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/124143/diff/
>
>
> Testing
> -------
>
> I ran the unit test until it passed.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150624/49e08869/attachment.html>
More information about the Kde-frameworks-devel
mailing list