Review Request 124147: Create Data Dir If it Does Not Exist

Aleix Pol Gonzalez aleixpol at kde.org
Sun Jun 21 23:51:58 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124147/#review81637
-----------------------------------------------------------



src/ioslaves/http/kcookiejar/kcookieserver.cpp (line 55)
<https://git.reviewboard.kde.org/r/124147/#comment55944>

    No need to check, just QDir::mkpath.


- Aleix Pol Gonzalez


On June 22, 2015, 1:43 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124147/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 1:43 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Prevents a cold start bug when the data dir is not created. Also, by
> storing the file name as a member of the KCookieServer class we avoid
> calculating it every time cookies are saved.
> 
> 
> Diffs
> -----
> 
>   src/ioslaves/http/kcookiejar/kcookieserver.h f61c7d0e4da58b805565632cf3dd484445c21275 
>   src/ioslaves/http/kcookiejar/kcookieserver.cpp ac585a0b04637c485647564d18a89a75d6c11d97 
> 
> Diff: https://git.reviewboard.kde.org/r/124147/diff/
> 
> 
> Testing
> -------
> 
> Restarted kded5 with no file named kcookiejar inside ~/.local/share and with a regular file named kcookiejar in that location.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150621/c2e2d5bf/attachment.html>


More information about the Kde-frameworks-devel mailing list