Review Request 123872: Add TranslationDomain attribute to kconfig_compiler

[Chusslove Illich]

> On Јун 6, 2015, 10:21 пре п., David Faure wrote:
> > A test doesn't really need ki18n, it could just define its own i18n() function.
> > 
> > Alternatively, you can put the test in a higher level framework, like frameworkintegration.

I took the first approach, by adding a fake klocalizedstring.h in the test directory.


- Chusslove


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123872/#review81259
-----------------------------------------------------------


On Јун 21, 2015, 10:47 по п., Chusslove Illich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123872/
> -----------------------------------------------------------
> 
> (Updated Јун 21, 2015, 10:47 по п.)
> 
> 
> Review request for KDE Frameworks, Alexander Potashev and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> When using Ki18n as the translation system, library .kcfg files also need to specify the translation domain. This is analogous to the TRANSLATION_DOMAIN define in C++ code, and translationDomain attribute in .rc files.
> 
> 
> Diffs
> -----
> 
>   autotests/kconfig_compiler/CMakeLists.txt f73aec0 
>   autotests/kconfig_compiler/kconfigcompiler_test.cpp 77a31a3 
>   autotests/kconfig_compiler/klocalizedstring.h e69de29 
>   autotests/kconfig_compiler/test_translation.kcfg e69de29 
>   autotests/kconfig_compiler/test_translation_kde.cpp.ref e69de29 
>   autotests/kconfig_compiler/test_translation_kde.h.ref e69de29 
>   autotests/kconfig_compiler/test_translation_kde.kcfgc e69de29 
>   autotests/kconfig_compiler/test_translation_kde_domain.cpp.ref e69de29 
>   autotests/kconfig_compiler/test_translation_kde_domain.h.ref e69de29 
>   autotests/kconfig_compiler/test_translation_kde_domain.kcfgc e69de29 
>   autotests/kconfig_compiler/test_translation_kde_domain_main.cpp e69de29 
>   autotests/kconfig_compiler/test_translation_kde_main.cpp e69de29 
>   autotests/kconfig_compiler/test_translation_qt.cpp.ref e69de29 
>   autotests/kconfig_compiler/test_translation_qt.h.ref e69de29 
>   autotests/kconfig_compiler/test_translation_qt.kcfgc e69de29 
>   autotests/kconfig_compiler/test_translation_qt_main.cpp e69de29 
>   src/kconfig_compiler/kconfig_compiler.cpp 7160bb5 
> 
> Diff: https://git.reviewboard.kde.org/r/123872/diff/
> 
> 
> Testing
> -------
> 
> Compiles.
> 
> 
> Thanks,
> 
> Chusslove Illich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150621/30af1071/attachment.html>