Review Request 124104: Make it possible to use kconfig_compiler from different sources

Aleix Pol Gonzalez aleixpol at kde.org
Sun Jun 21 00:16:51 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124104/
-----------------------------------------------------------

(Updated June 21, 2015, 12:16 a.m.)


Status
------

This change has been marked as submitted.


Review request for Build System, KDE Frameworks, Matthew Dawson, and Harald Sitter.


Changes
-------

Submitted with commit 173b33592739f9a671f34eb816499ef32fe65c06 by Aleix Pol to branch master.


Repository: kconfig


Description
-------

Separates the tooling that is supposed to be used at run-time so that we can specify which to use explicitly.

Ideally this would be done automagically, for now we'll have to specify -DKF5ConfigCompiler_DIR=...

Additionally, we should make kconfig_compiler co-installable by putting it in libexec, but I'd prefer to do that in a future patch. This same process should also happen on other frameworks.


Diffs
-----

  CMakeLists.txt f510e3e 
  KF5ConfigConfig.cmake.in b4e5f56 
  src/kconfig_compiler/CMakeLists.txt ec4a733 

Diff: https://git.reviewboard.kde.org/r/124104/diff/


Testing
-------

Works as expected on my debian chroot environment.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150621/2e6b286b/attachment.html>


More information about the Kde-frameworks-devel mailing list