Review Request 124134: Fixing KDED string references

Vishesh Handa me at vhanda.in
Sat Jun 20 17:57:42 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124134/#review81598
-----------------------------------------------------------

Ship it!


Looks good.

- Vishesh Handa


On June 20, 2015, 5:26 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124134/
> -----------------------------------------------------------
> 
> (Updated June 20, 2015, 5:26 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Changed to kded5.
> 
> 
> Diffs
> -----
> 
>   src/kcms/kio/kcookiesmain.cpp c4e36ac69e64f0540167e2a68cd8dadde4333450 
>   src/kcms/kio/kcookiesmanagement.cpp c041fc2f2e1a162ced43c944baeec1784e0bcca9 
>   src/kcms/kio/kcookiespolicies.cpp 7470616a130decb4261698aa4d4dc3da5c68ec22 
>   src/kcms/kio/ksaveioconfig.cpp 82ca6d9c90a58190d912f0f0c791c5e229254ec6 
> 
> Diff: https://git.reviewboard.kde.org/r/124134/diff/
> 
> 
> Testing
> -------
> 
> Notice that I was only able to test this with the 5.10 tag since I don't have the rest of the 5.11 frameworks.
> 
> Before this patch, if you made sure kded4 was not running and you tried 
> 
> $ kcmshell5 cookies
> 
> a message would pop up saying the cookies service was not available. After this patch you are able to view and edit your cookies. After this patch I also have ~/.config/kcookiejarrc.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150620/1df87cc3/attachment.html>


More information about the Kde-frameworks-devel mailing list