Review Request 123890: Don't show "KDE Frameworks version" in the About KDE dialog

Albert Astals Cid aacid at kde.org
Sat Jun 20 04:34:23 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123890/#review81587
-----------------------------------------------------------


Since there's an informal +1 and no disagreement i'll commit it in a few days.

- Albert Astals Cid


On mai. 24, 2015, 4:26 a.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123890/
> -----------------------------------------------------------
> 
> (Updated mai. 24, 2015, 4:26 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> Doesn't make sense, if you want to know which frameworks version you're using you can use the application dialog version, this is about kde, and as such it's about the community, the frameworks version there matters nothing
> 
> 
> Diffs
> -----
> 
>   src/kaboutkdedialog_p.cpp 1c3539b 
> 
> Diff: https://git.reviewboard.kde.org/r/123890/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150620/1944bcae/attachment.html>


More information about the Kde-frameworks-devel mailing list