Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog
Sebastian Kügler
sebas at kde.org
Sat Jun 20 04:33:41 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124133/#review81586
-----------------------------------------------------------
+1, this is useful and a clean implementation IMO.
- Sebastian Kügler
On June 20, 2015, 4:30 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124133/
> -----------------------------------------------------------
>
> (Updated June 20, 2015, 4:30 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kxmlgui
>
>
> Description
> -------
>
> This replaces the version information of the version and frameworks and
> moves it into a dedicated tab. In this tab the information is extended
> by the Qt version (which is equally relevant as e.g. the frameworks
> version) in both runtime and compile time.
>
> Also windowing system is added. This will become a useful information
> for KWin developers starting in Plasma 5.4 when users start to test
> things out and we need to know whether the window they experience the
> problem with is running on wayland or xwayland.
>
>
> Diffs
> -----
>
> src/kaboutapplicationdialog.cpp 5eeea7711aa4f95a9cd4191d68ad330ef795caea
>
> Diff: https://git.reviewboard.kde.org/r/124133/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> New wayland, new X11, old X11
> https://git.reviewboard.kde.org/media/uploaded/files/2015/06/20/b76ba6ae-b01c-4c6a-9248-29d39c652d83__snapshot_J11265.png
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150620/17fbdbd1/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list