Review Request 124128: KDirWatch: Only establish a connection to FAM if requested

Vishesh Handa me at vhanda.in
Fri Jun 19 17:04:43 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124128/
-----------------------------------------------------------

Review request for KDE Frameworks and David Edmundson.


Repository: kcoreaddons


Description
-------

KDirWatch by default initializes a connection to both inotify and FAM,
even if we aren't going to be using either. This is unnecessary and the
FAM backend has caused it to block for a while on running FAMOpen.


Diffs
-----

  src/lib/io/kdirwatch.cpp 246be82929cc08e40bd9eceec017036ec4686c26 

Diff: https://git.reviewboard.kde.org/r/124128/diff/


Testing
-------

Unit tests pass


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150619/4b6e5258/attachment.html>


More information about the Kde-frameworks-devel mailing list