Review Request 124116: KPlotWidget: no need to setMinimumSize or resize.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124116/
-----------------------------------------------------------

(Updated June 18, 2015, 8:20 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Christoph Feck.


Changes
-------

Submitted with commit 0bf18269a1a5e75f619751e6783eafe079fd5bac by David Faure to branch master.


Repository: kplotting


Description
-------

The minimumSizeHint() implementation (and the default size policy)
already sets a minimum size. Let users of the class call
setMinimumSize if they want to, and let Qt resize to the sizeHint()
by default, that's what it's for.


Diffs
-----

  src/kplotwidget.cpp 6122e2f0987998601ff6d0fd9437eb122c031839 

Diff: https://git.reviewboard.kde.org/r/124116/diff/


Testing
-------

The example looks like it did before ;)
In my app it works too.

Next step: changing that minimum size hint to 100 for the height, there's no reason to require 150 pixels vertically for a small graph.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150618/8bddff0b/attachment.html>