Review Request 124118: Make it possible to use KCoreAddons's desktoptojson in cross-compiled environments

[Alex Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124118/#review81544
-----------------------------------------------------------



autotests/CMakeLists.txt (line 49)
<https://git.reviewboard.kde.org/r/124118/#comment55894>

    I have no experience with cross compiling, but shouldn't this be `if(NOT ...)` as now the test will only be compiled when crosscompiling?


- Alex Richardson


On June 18, 2015, 2:39 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124118/
> -----------------------------------------------------------
> 
> (Updated June 18, 2015, 2:39 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Follows the lead of kconfig patch: https://git.reviewboard.kde.org/r/124104/
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 552851d 
>   KF5CoreAddonsConfig.cmake.in caa1c0a 
>   autotests/CMakeLists.txt 51fcfb4 
>   src/desktoptojson/CMakeLists.txt e6041cb 
> 
> Diff: https://git.reviewboard.kde.org/r/124118/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150618/446bb215/attachment.html>