Review Request 124066: Recognize X-KDE-FormFactor as stringlist

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124066/
-----------------------------------------------------------

(Updated June 17, 2015, 11 p.m.)


Review request for KDE Frameworks, Alex Richardson and David Faure.


Changes
-------

Add QStringList KPluginMetaData::formFactors() API, incl. autotest.


Repository: kcoreaddons


Description
-------

This patch adds X-KDE-FormFactor to the keys recognized as stringlists.

We would like to see this to go in to allow us to filter plugins (KCMs for example) by form factor, so we only display UI plugins that are suitable for a given target device.

The idea is that plugins indicate which form factor (for example media center, tablet, desktop, etc...) they're suitable for, and the "host application" filters based on these.

If this approach is deemed valid, I'd be happy to add convenience API to KPluginMetaData, i.e. QStringList KPluginMetaData::formFactor(). This patch would be the minimal implementation we'd need.

The naming of the key is of course open to better suggestions.


Diffs (updated)
-----

  autotests/data/fakeplugin.desktop 95152f6 
  autotests/kpluginmetadatatest.cpp 231ac36 
  src/lib/plugin/desktopfileparser.cpp b19da6b 
  src/lib/plugin/kpluginmetadata.h 4572d36 
  src/lib/plugin/kpluginmetadata.cpp eaaf0b9 

Diff: https://git.reviewboard.kde.org/r/124066/diff/


Testing
-------

added autotest, also implemented using this in the Plasma Active settings app as proof-of-concept, works like a charm.


Thanks,

Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150617/753524f8/attachment.html>