Review Request 124101: Reenable support for KDateTime streaming to kDebug/qDebug, for more SC

David Faure faure at kde.org
Wed Jun 17 07:29:01 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124101/#review81521
-----------------------------------------------------------

Ship it!


Yes. I think it was disabled while moving stuff around into different repos, at some point kdebug must have moved before kdatetime.

- David Faure


On June 15, 2015, 11:01 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124101/
> -----------------------------------------------------------
> 
> (Updated June 15, 2015, 11:01 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> When porting code to KF5 while using kdelibs4support, `kDebug() << someKDateTimeObject;` will not build. Because for some undocumented reason (at least in current repo, did not investigate further) `QDebug operator<<(QDebug s, const KDateTime &time);` had been disabled.
> 
> I could not see any problems after reenabling it again. So would propose to do it for everyone, to make kdelibs4support a tiny bit more source-compatible for kdelibs4-using code :)
> 
> 
> Diffs
> -----
> 
>   src/kdecore/kdebug.h ff7607f 
>   src/kdecore/kdebug.cpp 2705ec9 
> 
> Diff: https://git.reviewboard.kde.org/r/124101/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150617/a23dca33/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list