Review Request 123031: Let Kross be useable w/o searching for private deps

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123031/#review81468
-----------------------------------------------------------


Sorry for the slow reply!

I think you should be finding QtWidgets, as linking to the GUI target will fail otherwise. From a practical point of view, Kross isn't going to be installed if QtWidgets isn't present, so it shouldn't be an issue. If it is (or becomes) possible to build Kross without the GUI part, then the find_dependency call for QtWidgets should be omitted only when Kross is built in that way.

- Alex Merry


On May 26, 2015, 8:04 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123031/
> -----------------------------------------------------------
> 
> (Updated May 26, 2015, 8:04 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks and Alex Merry.
> 
> 
> Repository: kross
> 
> 
> Description
> -------
> 
> Only search for public deps in cmake config.
> 
> Open question - shall we search *all* public deps, or minimal ones? e.g. target 1 link Qt5Core, target 2 links Qt5Gui. Do we search for both, or just Qt5Core?
> 
> 
> Diffs
> -----
> 
>   KF5KrossConfig.cmake.in e89cee2 
> 
> Diff: https://git.reviewboard.kde.org/r/123031/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150614/6c4ec3a8/attachment.html>