Review Request 124062: Verify service has valid plugin info before using it

Marco Martin notmart at gmail.com
Thu Jun 11 18:06:21 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124062/#review81390
-----------------------------------------------------------

Ship it!


very odd they they are getting listed but still invlid, so a warning makes sense, other than that, go for it

- Marco Martin


On June 10, 2015, 4:39 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124062/
> -----------------------------------------------------------
> 
> (Updated June 10, 2015, 4:39 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Basically the same as 8a6c0b00979d235f68c46de761ba030848591247 in plasma-workspace but done at a higher level as applet listing occurs in more places.
> 
> 
> Diffs
> -----
> 
>   src/plasma/pluginloader.cpp 8b32f91306ed73777c3fc0e1bddc0bc014897cc1 
> 
> Diff: https://git.reviewboard.kde.org/r/124062/diff/
> 
> 
> Testing
> -------
> 
> krunner stops crashing when listing applets.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150611/0db51535/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list