Review Request 124065: KMimeType mimeTypeForNameAndData() -> mimeTypeForFileNameAndData()

Laurent Montel montel at kde.org
Thu Jun 11 04:37:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124065/#review81375
-----------------------------------------------------------

Ship it!


Indeed it was renamed in QMineDatabase and we forgot to update script.
Ship it.
Thanks

- Laurent Montel


On juin 10, 2015, 7:51 après-midi, Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124065/
> -----------------------------------------------------------
> 
> (Updated juin 10, 2015, 7:51 après-midi)
> 
> 
> Review request for KDE Frameworks and Laurent Montel.
> 
> 
> Repository: kde-dev-scripts
> 
> 
> Description
> -------
> 
> There's apparent mistake; mimeTypeForNameAndData() does not exist, shall be mimeTypeForFileNameAndData().
> 
> 
> Diffs
> -----
> 
>   kf5/convert-kmimetype.pl 363ff21cd46331efe209a5051feca58e971739b2 
> 
> Diff: https://git.reviewboard.kde.org/r/124065/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150611/094e2f02/attachment.html>


More information about the Kde-frameworks-devel mailing list