Review Request 123735: version of QmlObject with a static engine
Marco Martin
notmart at gmail.com
Wed Jun 10 16:41:39 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/
-----------------------------------------------------------
(Updated June 10, 2015, 4:41 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
-------
Submitted with commit 5f7909408e30869980552b9d74ded57a4f8a6621 by Marco Martin to branch master.
Repository: kdeclarative
Description
-------
to make easier doing applications like plasma that use a lot of qml to have a single engine make a subclass of QmlObject called QmlObjectSharedEngine that has a single, static QQmlEngine
Adds a class called QuickViewSharedEngine that has the same behavior as QmlObjectSharedEngine(using it): static QQmlEngine, separed rootContexts() for each instance.
This is used by desktopviews and panelviews to share their engine.
Unfortunately it may not be possible to get the applet configuration dialogs to use this, since they still need a separed engine in order to have a different controls style (qstyle based) than the stuff in the desktop/panel
Diffs
-----
autotests/CMakeLists.txt adc1102
autotests/quickviewsharedengine.cpp PRE-CREATION
autotests/util.h PRE-CREATION
autotests/util.cpp PRE-CREATION
src/kdeclarative/CMakeLists.txt d73bff0
src/kdeclarative/kdeclarative.cpp b3906e2
src/kdeclarative/qmlobject.h f26b67d
src/kdeclarative/qmlobject.cpp c483665
src/kdeclarative/qmlobjectsharedengine.h PRE-CREATION
src/kdeclarative/qmlobjectsharedengine.cpp PRE-CREATION
src/quickaddons/CMakeLists.txt 777d07c
src/quickaddons/quickviewsharedengine.h PRE-CREATION
src/quickaddons/quickviewsharedengine.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/123735/diff/
Testing
-------
Thanks,
Marco Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150610/be0694dd/attachment.html>
More information about the Kde-frameworks-devel
mailing list