Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

Milian Wolff mail at milianw.de
Sat Jun 6 21:27:31 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124032/
-----------------------------------------------------------

(Updated June 6, 2015, 9:27 p.m.)


Review request for KDE Frameworks and David Faure.


Repository: kio


Description (updated)
-------

BUG: 346920
REVIEW: 124032

Add unit test for user completion when '~' is inserted.


Diffs (updated)
-----

  autotests/kurlcompletiontest.cpp 55bd38011c93ea2d35a53a911a4878f28a09c00c 
  src/widgets/kurlcompletion.cpp d7ae787e6c3d1dba1a168e77cc2d5001b4bed7ef 

Diff: https://git.reviewboard.kde.org/r/124032/diff/


Testing
-------

added a unit test, it now passes. also kate and the manual kurlrequestertest_gui test don't crash anymore when I insert "~/." into a url requester.


Thanks,

Milian Wolff

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150606/5775dfa9/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list