Review Request 124014: Add QQC clone of KColorButton

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124014/#review81262
-----------------------------------------------------------



src/qmlcontrols/kquickcontrols/ColorButton.qml (lines 94 - 95)
<https://git.reviewboard.kde.org/r/124014/#comment55674>

    Now you get half the opacity
    
    opacity is set to the color's opacity but the color also has the opacity.
    
    Either use Qt.rgba(color.r, color.g, color.b, 1) or just drop the opacity


- Kai Uwe Broulik


On Juni 6, 2015, 10:23 vorm., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124014/
> -----------------------------------------------------------
> 
> (Updated Juni 6, 2015, 10:23 vorm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Add QQC clone of KColorButton. 
> 
> It's being used by SystemLoadViewer Plasmoid, Kai's clock review, and a mod I'm doing for the notes plasmoid and it's something we'll want to have.
> 
> High DPI support works perfectly as these are device independent pixels.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrols/CMakeLists.txt b7c08d7bcb46e53407d4b44fa593346f9d0a2137 
>   src/qmlcontrols/kquickcontrols/ColorButton.qml PRE-CREATION 
>   src/qmlcontrols/kquickcontrols/qmldir 31d8b145bf50491f94a14ba317b215fd6cc0ca32 
>   tests/colorButtonTest.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124014/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150606/31797aeb/attachment.html>