Review Request 124014: Add QQC clone of KColorButton

[David Edmundson]

> On June 5, 2015, 3:44 p.m., Marco Martin wrote:
> > for qstyle based stuff we are depending on the qt devicepixelratio var, right?

For all QQC stuff, yes.


> On June 5, 2015, 3:44 p.m., Marco Martin wrote:
> > src/qmlcontrols/kquickcontrols/ColorButton.qml, line 40
> > <https://git.reviewboard.kde.org/r/124014/diff/1/?file=378857#file378857line40>
> >
> >     this may look very different with different qstyles? (like oxygen that has huge margin/border area around buttons)

It looks OK on what I tested. I know it's not ideal, but nothing we have is (units wouldn't help)

Basically I need QStyle::sizeFromContents() but I can't use that because:
- it's not exported in any public API
- we should work with all QQC themes and not just assume it's running the desktop one.

You'd think one could probe the style.padding, but for the QQC desktop theme that's not set properly.

Hopefully at the end of the Qt Contributor Summit, I'll be able to come back with a solution for a future Qt, and then we'll only have to fix it in this one place.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124014/#review81233
-----------------------------------------------------------


On June 5, 2015, 10:46 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124014/
> -----------------------------------------------------------
> 
> (Updated June 5, 2015, 10:46 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Add QQC clone of KColorButton. 
> 
> It's being used by SystemLoadViewer Plasmoid, Kai's clock review, and a mod I'm doing for the notes plasmoid and it's something we'll want to have.
> 
> High DPI support works perfectly as these are device independent pixels.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrols/CMakeLists.txt b7c08d7bcb46e53407d4b44fa593346f9d0a2137 
>   src/qmlcontrols/kquickcontrols/ColorButton.qml PRE-CREATION 
>   src/qmlcontrols/kquickcontrols/qmldir 31d8b145bf50491f94a14ba317b215fd6cc0ca32 
>   tests/colorButtonTest.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124014/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150606/dfd4644f/attachment.html>