Review Request 123872: Add TranslationDomain attribute to kconfig_compiler

David Faure faure at kde.org
Sat Jun 6 08:21:21 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123872/#review81259
-----------------------------------------------------------


A test doesn't really need ki18n, it could just define its own i18n() function.

Alternatively, you can put the test in a higher level framework, like frameworkintegration.

- David Faure


On May 21, 2015, 3:21 p.m., Chusslove Illich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123872/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 3:21 p.m.)
> 
> 
> Review request for KDE Frameworks, Alexander Potashev and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> When using Ki18n as the translation system, library .kcfg files also need to specify the translation domain. This is analogous to the TRANSLATION_DOMAIN define in C++ code, and translationDomain attribute in .rc files.
> 
> 
> Diffs
> -----
> 
>   src/kconfig_compiler/kconfig_compiler.cpp 7160bb5 
> 
> Diff: https://git.reviewboard.kde.org/r/123872/diff/
> 
> 
> Testing
> -------
> 
> Compiles.
> 
> 
> Thanks,
> 
> Chusslove Illich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150606/8c558ad9/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list