Review Request 123929: If double-click is on empty area, then invoke back. (kfilewidgets)

[Thomas Pfeiffer]

> On May 29, 2015, 12:45 p.m., David Faure wrote:
> > I'm not sure this is a good idea, usability wise. Miss an icon by one pixel, and the effect is to go up, making the whole set of icons disappear?
> 
> Ashish Bansal wrote:
>     Well about usability there's already discussion going on dolphin RR 123658. Single click is the way to select a directory(atleast by default). So, even if someone wants to select an directory and misses it, it won't go up. Go up behaviour is only when one would use double click :)
> 
> David Faure wrote:
>     Well, it would still be a huge problem for people using double-click mode (e.g. my wife).
> 
> David Faure wrote:
>     Maybe this feature should only be activated in single-click-mode.
> 
> Ashish Bansal wrote:
>     That sounds good!
> 
> Arjun AK wrote:
>     >Maybe this feature should only be activated in single-click-mode.
>     
>     Are you sure thats a good idea? If i disable/enable single click mode, it should only change that behaviour and not add/remove a completely unrelated feature.
> 
> Martin Klapetek wrote:
>     I agree with Arjun; plus if you change the behavior in one patch, the other one must stay consistent (123658).
> 
> David Faure wrote:
>     I don't agree that it's unrelated. If two features conflict, then we shouldn't enable them together.
>     
>     single-click mode = single-click to execute. double-click is not used.
>     double-click mode = single-click to select, double-click to execute.
>     
>     The only mode where double-click is currently unused is single-click mode.

This is a valid and correctly identified problem, but I do not agree with the proposed solution.
If there's a considerable chance that people may miss an icon they wanted to click, then we have to fix that, instead of working around the problem by changing the behavior of another feature depending on whether one selects by single or double click.

As far as I understood, this feature was meant to affect only truly empty areas, where there simply are no icons, not the space between two icons. That still leaves us with mis-clicks below the last row of icons, but with a big enough hit area, the chances for that should not be too big.

This is also something we could test, though: We could ask our beta testers (or better still, those using Kubuntu CI images) to test this feature out in both single- and double-click mode and report back problems, so we could refine the size of the hit areas until we can reduce mis-clicks to a low-enough rate. Mis-clicking is bad as it is, even if nothing happens.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123929/#review80946
-----------------------------------------------------------


On May 30, 2015, 12:42 p.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123929/
> -----------------------------------------------------------
> 
> (Updated May 30, 2015, 12:42 p.m.)
> 
> 
> Review request for Dolphin, KDE Frameworks, KDE Usability, David Faure, and Martin Klapetek.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> If mouse double click is done on the empty area, then go to parent directory.
> 
> RR 123658 (dolphin)
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/kdiroperator.h 6d601f3 
>   src/filewidgets/kdiroperator.cpp 4a7ef02 
> 
> Diff: https://git.reviewboard.kde.org/r/123929/diff/
> 
> 
> Testing
> -------
> 
> Works fine!
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150601/5d483a45/attachment.html>