Review Request 123975: Fix crash in NotifyByExecute when no widget has been set

[Martin Klapetek]

> On June 1, 2015, 2:40 p.m., David Edmundson wrote:
> > src/notifybyexecute.cpp, line 56
> > <https://git.reviewboard.kde.org/r/123975/diff/1/?file=378610#file378610line56>
> >
> >     should this have an 
> >     
> >     else subst.insert("w", 0); ?
> >     
> >     otherwise it won't be substituted out and the receiving process will get an unepected letter.

Good point, I'll fix.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123975/#review81044
-----------------------------------------------------------


On June 1, 2015, 1:51 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123975/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 1:51 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 348510
>     https://bugs.kde.org/show_bug.cgi?id=348510
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> Additionally, it makes the debug output a bit more useful.
> 
> 
> Diffs
> -----
> 
>   src/knotification.cpp 790ff3f 
>   src/notifybyexecute.cpp b5d437a 
> 
> Diff: https://git.reviewboard.kde.org/r/123975/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150601/8615ad99/attachment.html>