Review Request 124557: Fix method behavior KShortcutsEditorPrivate::importConfiguration
Aleix Pol Gonzalez
aleixpol at kde.org
Fri Jul 31 15:49:47 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124557/
-----------------------------------------------------------
(Updated July 31, 2015, 3:49 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Changes
-------
Submitted with commit 21b677216bcd1b184fa3559032c124bfcad27d2e by Aleix Pol to branch master.
Repository: kxmlgui
Description
-------
Only modify the shortcuts if they're specified on the file.
Use proper variable locality.
Get the configuration key correctly, as exported: Use Id instead of Name.
Diffs
-----
src/kshortcutseditor.cpp 9b1f42a
Diff: https://git.reviewboard.kde.org/r/124557/diff/
Testing
-------
I added an import feature, see further patch.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150731/57b36a4a/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list