Review Request 124542: CMake fixes for Windows build

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124542/#review83214
-----------------------------------------------------------


This is not ideal indeed, because URIs usually contain a real ':' : like the one after the scheme, which I suppose shouldn't be escaped.

I think the bug is before this code gets called, because a URL like  file:///R:/path is broken in the first place. (do I understand it right that this is what this function is getting as input?)


src/CMakeLists.txt (line 20)
<https://git.reviewboard.kde.org/r/124542/#comment57460>

    no-op?


- David Faure


On July 31, 2015, 7:34 a.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124542/
> -----------------------------------------------------------
> 
> (Updated July 31, 2015, 7:34 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> BUG: 348061
> 
> 
> Diffs
> -----
> 
>   cmake/uriencode.cmake e5f3c3acd93d3871e44b6e6fb29ad7113e18d751 
>   src/CMakeLists.txt e3868fc4f22324d25f680c13609bfb92b8b7c41d 
> 
> Diff: https://git.reviewboard.kde.org/r/124542/diff/
> 
> 
> Testing
> -------
> 
> Adding ':' to the list of escaped characters is probably not an ideal solution, but let me hear your ideas.
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150731/6413c823/attachment.html>