Review Request 124397: Add today button to calendar

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124397/#review83118
-----------------------------------------------------------



src/declarativeimports/calendar/qml/DaysCalendar.qml (lines 71 - 74)
<https://git.reviewboard.kde.org/r/124397/#comment57389>

    Since you've change the parent to be RowLayout, these anchors don't make sense anymore (as any other anchors of the children), instead the RowLayout should be anchored more precisely than "fill: parent" and it should have the proper height set



src/declarativeimports/calendar/qml/DaysCalendar.qml (lines 147 - 149)
<https://git.reviewboard.kde.org/r/124397/#comment57390>

    Given this is only used here, would it make more sense to actually move the function here? Having it on the main item does not seem to bring any advantages...


- Martin Klapetek


On July 28, 2015, 10:32 p.m., Bernhard Friedreich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124397/
> -----------------------------------------------------------
> 
> (Updated July 28, 2015, 10:32 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 348362
>     http://bugs.kde.org/show_bug.cgi?id=348362
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Add button "Select Today" to calendar title bar
>     
> BUG: 348362
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 35a1e202ced1c050479ed04d71d8976a4e03a12c 
> 
> Diff: https://git.reviewboard.kde.org/r/124397/diff/
> 
> 
> Testing
> -------
> 
> plasmoidviewer with digitalclock plasmoid
> added digitalclock plasmoid to desktop
> 
> clicked digital clock plasmoid to view calendar
> "Select Today" button is shown
> select different day
> clicked button -> selection changes to today
> moved to another month/month selection/year/year selection -> clicked button --> jumps to today
> 
> 
> File Attachments
> ----------------
> 
> Plasmoidviewer Digital Clock showing Calendar with Today ToolButton
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png
> 
> 
> Thanks,
> 
> Bernhard Friedreich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150728/5592d7b8/attachment-0001.html>