Review Request 124487: Couple misc small fixes in kwallet

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124487/
-----------------------------------------------------------

(Updated July 28, 2015, 10:09 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Valentin Rusu.


Changes
-------

Submitted with commit 1713ef8ef1e9eddb042e3d10b88a33a00c2a4409 by Martin Klapetek to branch master.


Repository: kwallet


Description
-------

[theese will be separate commits]

In the kwalletbackend.cc, all error codes are negative, I assume
the "unknown cipher or hash" is also an error code and as such
should be negative?

When trying to open the backend in KWalletD::pamOpen, return the
return code from the backend rather than -1. I'm not sure if there
is perhaps an intent to always return -1 here though, but returning
the actual return code seems more useful.


Diffs
-----

  src/runtime/kwalletd/backend/kwalletbackend.cc 34e0419 
  src/runtime/kwalletd/kwalletd.cpp c40289a 
  src/runtime/kwalletd/main.cpp 46ba2e6 

Diff: https://git.reviewboard.kde.org/r/124487/diff/


Testing
-------


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150728/e991eb82/attachment.html>