Review Request 124487: Couple misc small fixes in kwallet

[Valentin Rusu]

> On July 27, 2015, 1:15 p.m., Aleix Pol Gonzalez wrote:
> > src/runtime/kwalletd/main.cpp, line 213
> > <https://git.reviewboard.kde.org/r/124487/diff/1/?file=388026#file388026line213>
> >
> >     qCDebug?
> 
> Martin Klapetek wrote:
>     KWallet does not use qCDebug, so..perhaps in another patch?
> 
> Aleix Pol Gonzalez wrote:
>     ok.

qCDebug => that's a new requirement, that have changed since the KF5 porting?


- Valentin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124487/#review83044
-----------------------------------------------------------


On July 27, 2015, 11:22 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124487/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 11:22 a.m.)
> 
> 
> Review request for KDE Frameworks and Valentin Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> [theese will be separate commits]
> 
> In the kwalletbackend.cc, all error codes are negative, I assume
> the "unknown cipher or hash" is also an error code and as such
> should be negative?
> 
> When trying to open the backend in KWalletD::pamOpen, return the
> return code from the backend rather than -1. I'm not sure if there
> is perhaps an intent to always return -1 here though, but returning
> the actual return code seems more useful.
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwalletd/backend/kwalletbackend.cc 34e0419 
>   src/runtime/kwalletd/kwalletd.cpp c40289a 
>   src/runtime/kwalletd/main.cpp 46ba2e6 
> 
> Diff: https://git.reviewboard.kde.org/r/124487/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150727/72233f53/attachment.html>