Review Request 124372: Fix crash when MigrationAgent::isEmptyOldWallet() check fails

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124372/
-----------------------------------------------------------

(Updated July 27, 2015, 12:58 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Valentin Rusu.


Changes
-------

Submitted with commit f0687b807e98d9adf974b15442d3f030416345e1 by Dan Vrátil to branch master.


Repository: kwallet


Description
-------

When the DBus call in `invokeAndCheck()` fails when called from `MigrationAgent::isEmptyOldWallet()`, the code would crash because the `migrationAgent` global variable was not set (it's only set in `MigrationAgent::performMigration()`). Since global variables are evil ;-), this patch makes the `invokeAndCheck()` template to take the `MigrationAgent` instance pointer as an argument.


Diffs
-----

  src/runtime/kwalletd/migrationagent.cpp a2a6498 

Diff: https://git.reviewboard.kde.org/r/124372/diff/


Testing
-------


Thanks,

Daniel Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150727/fae6c865/attachment.html>