Review Request 124474: KCharSelect - fit contents to width

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124474/#review83000
-----------------------------------------------------------

Ship it!


Looks good to me.

- David Faure


On July 26, 2015, 4:35 p.m., Rajeesh K Nambiar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124474/
> -----------------------------------------------------------
> 
> (Updated July 26, 2015, 4:35 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> When displaying non-Latin character sets (for instance Malayalam[ml_IN] in South Asian languages group), letters were not fitting in table cell contents and get truncated. See screenshots. Fix this by calling QTableView=>resizeColumnsToContents().
> 
> 
> Diffs
> -----
> 
>   src/kcharselect.cpp 06c52c2 
> 
> Diff: https://git.reviewboard.kde.org/r/124474/diff/
> 
> 
> Testing
> -------
> 
> Tested with South Asian languages, Latin (basic and extended) character sets. Didn't notice any regression.
> 
> 
> File Attachments
> ----------------
> 
> KCharSelect before
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/26/b14b2712-2061-46db-a282-ee2a3905ac0e__kcharselect-before.png
> KCharSelect after
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/26/b9ae10fe-8963-4652-88ed-02e1b79f88f2__kcharselect-after.png
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150726/1994d384/attachment-0001.html>