Review Request 124281: Remove KService and KIconThemes usage from KNotifications

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124281/
-----------------------------------------------------------

(Updated July 21, 2015, 6:39 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Gräßlin.


Changes
-------

Submitted with commit ba267253dbaeac32bb033e2f519d10651075c766 by Martin Klapetek to branch master.


Repository: knotifications


Description
-------

This patch reduces the dependencies of KNotifications framework and effectively makes it a tier 2 framework.

KService is used only for locating additional notification plugins and to my knowledge,
there are none such plugins currently existing, at least not in all around KDE plus
the class for the plugins wasn't exported until about two months ago, so this should
be safe without a legacy support.

KIconThemes is used only to get "KIconLoader::Small" icon pixmap for notifications
using KPassivePopup. After some playing around it turns out that it puts the icon into
the KPassivePopup title and makes it as big as the text. So I've made the icon size to
be the same as the text height. So this keeps things visually the same + still DPI aware,
though I believe the KPassivePopup should receive a complete visual overhaul anyway.

Additionally, KCodecs dependency has again one single usage for decoding html entities
to QChars within QXmlStreamReader parser, so eventually could also be removed/replaced
with QTextDocument::toPlainText() which seems to do the same job as QXmlStreamReader+KCodecs.


Diffs
-----

  CMakeLists.txt 7b600a4 
  metainfo.yaml 7fc15f7 
  src/CMakeLists.txt 1cebece 
  src/knotificationmanager.cpp 8d4f953 
  src/knotificationplugin.cpp 7315c17 
  src/notifybypopup.cpp bb96465 
  tests/kpassivepopuptest.h bc0dedc 
  tests/kpassivepopuptest.cpp 2486fd8 

Diff: https://git.reviewboard.kde.org/r/124281/diff/


Testing
-------

Everything still compiles + I added a test for KPassivePopup with an icon.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150721/445f40a1/attachment.html>