Review Request 124413: Enable PAM opening KWallet again

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124413/#review82770
-----------------------------------------------------------



src/runtime/kwalletd/main.cpp (line 113)
<https://git.reviewboard.kde.org/r/124413/#comment57076>

    You should use strncmp instead of strcmp.



src/runtime/kwalletd/main.cpp (line 126)
<https://git.reviewboard.kde.org/r/124413/#comment57078>

    You should use strtol() instead of atoi() for better error checking. atoi() does no error checking at all.



src/runtime/kwalletd/main.cpp (line 129)
<https://git.reviewboard.kde.org/r/124413/#comment57077>

    environment



src/runtime/kwalletd/main.cpp (line 144)
<https://git.reviewboard.kde.org/r/124413/#comment57079>

    You should deallocate hash here if it is not null, otherwise you have a memory leak.


- Lamarque Souza


On July 21, 2015, 3:52 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124413/
> -----------------------------------------------------------
> 
> (Updated July 21, 2015, 3:52 p.m.)
> 
> 
> Review request for KDE Frameworks, Àlex Fiestas and Valentin Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> This brings back Alex's patch in commit f2fe3e75b4ba12d0f99aa09327059a1865891b14 [1] which allows KWallet to be opened by PAM if kwallet-pam is present.
> 
> http://quickgit.kde.org/?p=kde-runtime.git&a=commit&h=f2fe3e75b4ba12d0f99aa09327059a1865891b14
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwalletd/main.cpp b4e3837 
> 
> Diff: https://git.reviewboard.kde.org/r/124413/diff/
> 
> 
> Testing
> -------
> 
> Logged in, KWallet does not ask for password anymore.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150721/34bd3634/attachment.html>