Review Request 123031: Let Kross be useable w/o searching for private deps

Alex Merry alex.merry at kde.org
Mon Jul 20 21:24:13 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123031/#review82733
-----------------------------------------------------------

Ship it!


Ship It!

- Alex Merry


On May 26, 2015, 8:04 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123031/
> -----------------------------------------------------------
> 
> (Updated May 26, 2015, 8:04 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks and Alex Merry.
> 
> 
> Repository: kross
> 
> 
> Description
> -------
> 
> Only search for public deps in cmake config.
> 
> Open question - shall we search *all* public deps, or minimal ones? e.g. target 1 link Qt5Core, target 2 links Qt5Gui. Do we search for both, or just Qt5Core?
> 
> 
> Diffs
> -----
> 
>   KF5KrossConfig.cmake.in e89cee2 
> 
> Diff: https://git.reviewboard.kde.org/r/123031/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150720/5ed4eef3/attachment.html>


More information about the Kde-frameworks-devel mailing list