Review Request 124397: Add today button to calendar

Kai Uwe Broulik kde at privat.broulik.de
Sun Jul 19 16:50:50 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124397/#review82653
-----------------------------------------------------------


Please include a screenshot for UI changes.

Also please wait until Review 122488 is merged to save me another rebase headache.


src/declarativeimports/calendar/qml/MonthView.qml (line 155)
<https://git.reviewboard.kde.org/r/124397/#comment57009>

    Should be "go-jump-today" I suppose



src/declarativeimports/calendar/qml/MonthView.qml (line 156)
<https://git.reviewboard.kde.org/r/124397/#comment57008>

    ToolButton is square by default



src/declarativeimports/calendar/qml/MonthView.qml (lines 161 - 164)
<https://git.reviewboard.kde.org/r/124397/#comment57007>

    ToolButton has a tooltip property, no need for a custom tooltip


- Kai Uwe Broulik


On Juli 19, 2015, 4:38 nachm., Bernhard Friedreich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124397/
> -----------------------------------------------------------
> 
> (Updated Juli 19, 2015, 4:38 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 348362
>     http://bugs.kde.org/show_bug.cgi?id=348362
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Add button "Select Today" to calendar title bar, aligned to the right
> Removed commented out code to jump to a specific date, this will likely
> be replaced by RR 122488
> 
> BUG: 348362
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/calendar/qml/MonthView.qml 601755f4e9f99618914099e35616e71c332ec7c4 
> 
> Diff: https://git.reviewboard.kde.org/r/124397/diff/
> 
> 
> Testing
> -------
> 
> plasmoidviewer with digitalclock plasmoid
> added digitalclock plasmoid to desktop
> 
> clicked digital clock plasmoid to view calendar
> "Select Today" button is shown
> clicked different day
> clicked button -> jumps to today
> moved to another month -> clicked button --> jumps to today
> 
> 
> Thanks,
> 
> Bernhard Friedreich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150719/b0f052c0/attachment.html>


More information about the Kde-frameworks-devel mailing list