Review Request 124371: Fix potential endless recursion in PlatformStatus::findLookAndFeelPackage()

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124371/
-----------------------------------------------------------

(Updated July 16, 2015, 1:13 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Marco Martin.


Changes
-------

Submitted with commit 2b31836bdc238a1817f931fd5328da8c5d9067ef by Dan Vrátil to branch master.


Repository: plasma-framework


Description
-------

The `LookAndFeel` entry does not exist in `kdeglobals` (it's called `LookAndFeelPackage`), so when the configured LnF package is removed or renamed, the code will go to endless loop because it never clears the configuration ine `kdeglobals` correctly.

We discovered this in Fedora, because we ship our own ugly LnF package, and we renamed it at some point, which caused KDED to go nuts.


Diffs
-----

  src/platformstatus/platformstatus.cpp e03c16d 

Diff: https://git.reviewboard.kde.org/r/124371/diff/


Testing
-------


Thanks,

Daniel Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150716/a3888deb/attachment.html>