Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124331/#review82536
-----------------------------------------------------------

Ship it!


Yu are right about QPMI, but it just shows again how much simpler the world would be if we'd simply use QVector everywhere. Ah, I'll continue to dream :)

Thanks for fixing it though!


src/kextracolumnsproxymodel.cpp (line 85)
<https://git.reviewboard.kde.org/r/124331/#comment56938>

    ah, a pity. Btw, in KDevelop where I can use lambdas (can you here?), I stopped using private signals and instead do something like
    
        connect(foo, &Foo::bar,
                this, [this] (...) { d->onBar(...); });
    
    I quite like that, as it does not leak anything to the public header at all.


- Milian Wolff


On July 15, 2015, 8:59 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124331/
> -----------------------------------------------------------
> 
> (Updated July 15, 2015, 8:59 a.m.)
> 
> 
> Review request for KDE Frameworks, Jesper Pedersen and Stephen Kelly.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> -------
> 
> REVIEW: 124331
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt f98e87d49b965998f31c5ede1fefb03b159a150f 
>   autotests/kextracolumnsproxymodeltest.cpp PRE-CREATION 
>   autotests/test_model_helpers.h a44db8a9cb985f69b52be96f0ffe389ebd903d6f 
>   src/CMakeLists.txt 82d776f1fcc2f7b15e74f0ed47702ed570ce9892 
>   src/kextracolumnsproxymodel.h PRE-CREATION 
>   src/kextracolumnsproxymodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124331/diff/
> 
> 
> Testing
> -------
> 
> Wrote autotests (as extensive as possible); used this in one real project, AFAIK Jesper (blackie) did as well.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150715/e28c4827/attachment.html>