Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

[David Faure]

> On July 15, 2015, 5:54 a.m., Sune Vuorela wrote:
> > src/kextracolumnsproxymodel.h, line 39
> > <https://git.reviewboard.kde.org/r/124331/diff/3/?file=385294#file385294line39>
> >
> >     Are there any of these "not supported" things we might want to support in the future? Can we implement e.g. adding/removing columns at runtime and still keep the abi/api ?
> >     I guess for removing columns, one could just add a QSFPM on top and filter out the column.

I don't know if any of this will be needed in the future, but the API will allow for it:
1) making appendColumn emit columnsInserted, if it should work with a live proxy
2) adding a removeExtraColumn method

"having a different number of columns in subtrees" isn't really useful with the available views from Qt anyway

dnd and move support is just more virtuals to reimplement. Ah, we won't be able to delegate to new virtuals though. So it'll have to be "reimplement the existing virtuals, e.g. dropMimeData, and check the column number", i.e. documenting how the app should do it.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124331/#review82521
-----------------------------------------------------------


On July 14, 2015, 10:42 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124331/
> -----------------------------------------------------------
> 
> (Updated July 14, 2015, 10:42 a.m.)
> 
> 
> Review request for KDE Frameworks, Jesper Pedersen and Stephen Kelly.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> -------
> 
> REVIEW: 124331
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt f98e87d49b965998f31c5ede1fefb03b159a150f 
>   autotests/kextracolumnsproxymodeltest.cpp PRE-CREATION 
>   autotests/test_model_helpers.h a44db8a9cb985f69b52be96f0ffe389ebd903d6f 
>   src/CMakeLists.txt 82d776f1fcc2f7b15e74f0ed47702ed570ce9892 
>   src/kextracolumnsproxymodel.h PRE-CREATION 
>   src/kextracolumnsproxymodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124331/diff/
> 
> 
> Testing
> -------
> 
> Wrote autotests (as extensive as possible); used this in one real project, AFAIK Jesper (blackie) did as well.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150715/d2a1eff5/attachment-0001.html>