Review Request 124105: Adhere a bit better to the spec

Aleix Pol Gonzalez aleixpol at kde.org
Mon Jul 13 18:48:46 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124105/#review82468
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On July 4, 2015, 9:18 p.m., Sune Vuorela wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124105/
> -----------------------------------------------------------
> 
> (Updated July 4, 2015, 9:18 p.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez, Christoph Feck, David Faure, Eike Hein, and Martin Klapetek.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> According to table 2 in the icon theme spec, the Context per directory key is optional, and the Type key defaults to Threshold if not specified. Let's make the code do the same.
> 
> 
> Diffs
> -----
> 
>   autotests/breeze.theme 8aef88d 
>   autotests/kiconloader_unittest.cpp d1a52fc 
>   src/kicontheme.cpp 4f0e522 
> 
> Diff: https://git.reviewboard.kde.org/r/124105/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sune Vuorela
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150713/98d47b5f/attachment.html>


More information about the Kde-frameworks-devel mailing list