Review Request 124328: Man pages for kapidox

Alex Merry alex.merry at kde.org
Sun Jul 12 09:33:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124328/#review82378
-----------------------------------------------------------

Ship it!


For all that troff is dark magic, the important parts of the file look easy to maintain (although I do wonder whether using help2man wouldn't be easier), so I'm happy to have this in if it makes downstreams' lives easier.


setup.py (lines 37 - 46)
<https://git.reviewboard.kde.org/r/124328/#comment56766>

    There's no need to repeat the destination directory - the second part of the tuple is a list, so all the files can go in a single list.


- Alex Merry


On July 11, 2015, 9:34 p.m., Scott Kitterman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124328/
> -----------------------------------------------------------
> 
> (Updated July 11, 2015, 9:34 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry, Aurélien Gâteau, and Kevin Krammer.
> 
> 
> Repository: kapidox
> 
> 
> Description
> -------
> 
> Add man pages for kapidox scripts
> 
> 
> Diffs
> -----
> 
>   docs/depdiagram-generate-all.1 PRE-CREATION 
>   docs/depdiagram-generate.1 PRE-CREATION 
>   docs/depdiagram-prepare.1 PRE-CREATION 
>   docs/kgenapidox.1 PRE-CREATION 
>   docs/kgenframeworksapidox.1 PRE-CREATION 
>   setup.py 083543f 
> 
> Diff: https://git.reviewboard.kde.org/r/124328/diff/
> 
> 
> Testing
> -------
> 
> Built and installed updated version and verified man pages were correctly installed and readable in the KDE man page viewer.
> 
> 
> Thanks,
> 
> Scott Kitterman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150712/5438a6b4/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list