Review Request 120909: in kio_smb: Set inode/directory mimetype for folders

Àlex Fiestas afiestas at kde.org
Sat Jul 11 20:21:48 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120909/
-----------------------------------------------------------

(Updated jul. 11, 2015, 8:21 p.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks and David Faure.


Repository: kio-extras


Description
-------

Set inode/directory mimetype for folders


Diffs
-----

  smb/kio_smb_browse.cpp 67e2fa0 

Diff: https://git.reviewboard.kde.org/r/120909/diff/


Testing
-------

Previously (kde4) KFileItem was doing an extra effort into figuring out the miemtype for remotes url but now it is not (at least not by default).

Since we already know that the item is a directory we can set the mimetype already, saving roundtrips and making samba kioslave show folder icons again (and faster since we save a stat).

Would be nice if somebody from frameworks (kio) could confirm that the situation regarding mimetypes in frameworks have changed.


Thanks,

Àlex Fiestas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150711/46695dc8/attachment.html>


More information about the Kde-frameworks-devel mailing list