Review Request 124226: Delete old highlighter

Laurent Montel montel at kde.org
Sat Jul 11 09:02:10 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124226/#review82351
-----------------------------------------------------------

Ship it!


Ship it.
Indeed I did it in kmail too.

Thanks

- Laurent Montel


On juil. 11, 2015, 8:18 matin, Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124226/
> -----------------------------------------------------------
> 
> (Updated juil. 11, 2015, 8:18 matin)
> 
> 
> Review request for KDE Frameworks and Laurent Montel.
> 
> 
> Repository: ktextwidgets
> 
> 
> Description
> -------
> 
> According to SpellCheckDecorator::setHighlighter's documentation, the old automatically created default highlighter must be manually deleted.
> 
> This fixes bug 343459 in Lokalize.
> 
> 
> Diffs
> -----
> 
>   src/widgets/ktextedit.cpp e4bd41d 
> 
> Diff: https://git.reviewboard.kde.org/r/124226/diff/
> 
> 
> Testing
> -------
> 
> Tested that it works in Lokalize. Also ran tests.
> 
> 
> Thanks,
> 
> Lasse Liehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150711/4fe8ae2a/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list