Review Request 124304: Reduce the KDBusService timeout from 5 minutes to 25 seconds

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124304/#review82311
-----------------------------------------------------------


Guys, shortening this value won't make anything faster. Instead, in case an app takes 26 seconds to start (slow machine, busy system, lots of initialization code...) the caller will get an error message erroneously.

Did you never see that in kdelibs4? Type kmail twice in a terminal, the first one goes through some slow path for some reason, and the second one tells you "DBus communication error, couldn't communicate with running instance blah blah". There's no error though.

Yes it's a blocking call, but it's done by the just-starting second-instance of the app, which has shown no GUI yet, so this isn't going to block some GUI for the user. Waiting is better than a wrong error IMHO.

- David Faure


On July 9, 2015, 11:48 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124304/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 11:48 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kdbusaddons
> 
> 
> Description
> -------
> 
> Now I don't know if that was perhaps intended, but 5 minute timeout on dbus call to activate an app seems a bit too much?
> 
> So I've reduced it to standard 25 seconds.
> 
> 
> Diffs
> -----
> 
>   src/kdbusservice.cpp ea7727d 
> 
> Diff: https://git.reviewboard.kde.org/r/124304/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150710/a364cf37/attachment.html>