Review Request 124282: Implement Voikko based spellchecker for Sonnet
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Jul 7 14:11:26 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124282/#review82174
-----------------------------------------------------------
src/plugins/voikko/voikkoclient.h (line 37)
<https://git.reviewboard.kde.org/r/124282/#comment56563>
it's override, no need to specify it's virtual.
src/plugins/voikko/voikkodict.cpp (line 71)
<https://git.reviewboard.kde.org/r/124282/#comment56567>
This line does nothing.
src/plugins/voikko/voikkodict.cpp (line 125)
<https://git.reviewboard.kde.org/r/124282/#comment56564>
use constFind, now you're looking up the word twice.
src/plugins/voikko/voikkodict.cpp (line 261)
<https://git.reviewboard.kde.org/r/124282/#comment56566>
qCDebug(SONNET_VOIKKO) << "Loaded" << words.size() << "replacements from the user dictionary.";
Same above.
I don't really know much about Voikko or even Sonnet, so just reviewing the code.
- Aleix Pol Gonzalez
On July 7, 2015, 4 p.m., Jesse Jaara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124282/
> -----------------------------------------------------------
>
> (Updated July 7, 2015, 4 p.m.)
>
>
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
>
>
> Repository: sonnet
>
>
> Description
> -------
>
> # Implement Voikko based spellchecker for Sonnet
>
> ## Description
> Implements a spell chekcing plugin based on libvoikko <http://voikko.puimula.org/>.
> Primarily for supporting highquality Finnishs spell checking, but HFST trancuders
> can be found several other languages too.
> <http://sourceforge.net/projects/hfst/files/resources/spell-transducers/>
>
>
> ## List of commits (oldest 1st)
> ---------------------------------------------------------------------------------------------------
>
> Define QLoggingCategory for for voikko speller plugin
>
> * Declared SONNET_VOIKKO QLoggingCategory
>
> --------------------------------------------------------------------------------------------------
>
> Implement Voikko based spellchecker (dictionary)
>
> * All Sonnet::SpellerPlugin functions are implemented.
> * storeReplacement() and addToPersonal() use Json based storage.
> * File location:
> * UNIX & OSX: QStandardPaths::GenericDataLocation/Sonnet/Voikko-user-dictionary.json
> * Windows >= Vista: QSP::GenericDataLocation/../Roaming/Sonnet/Voikko-user-dictionary.json
> * XP: QSP::GenericDataLocation/../../Aplication Data/Sonnet/Voikko-user-dictionary.json
> * Format:
> ```JSON
> { "<languageId>": {
> "PersonalWords": [
> "word"
> ],
> "Replacements": [
> {"bad": "eror",
> "good": "error"}
> ]
> }
> ```
> * Before use VoikkoDict based chekkers must be ensured to be with valid with initFailed().
> As so the ctor is protected and only accessible from friens class VoikkoClient, which
> does this check before returning the speller. Using an invalid speller will result in
> null-pointer exceptions.
>
> --------------------------------------------------------------------------------------------------
>
> Implement Sonnet::Client for Voikko speller
>
> * Reliability set to 50.
> Voikko is primarily only used for Finnish at the moment, although
> the HFST transducer-backend has added support for other languages
> of varying quality.
> As for Finnish (99% of use cases) the results are top quality.
>
> In any case the reliability should be higher than that of hunspell
> and aspell to prevent them from kicking in for Finnish, as the
> Finnish dictionarys for them are low-quality.
>
> * Name is "Voikko"
>
> --------------------------------------------------------------------------------------------------
>
> Add in CMakeBits needed to compile Voikko speller.
>
> * Added FindVOIKKO module
>
>
> Diffs
> -----
>
> cmake/FindVOIKKO.cmake PRE-CREATION
> src/plugins/CMakeLists.txt 3d24d61
> src/plugins/voikko/CMakeLists.txt PRE-CREATION
> src/plugins/voikko/voikkoclient.h PRE-CREATION
> src/plugins/voikko/voikkoclient.cpp PRE-CREATION
> src/plugins/voikko/voikkodebug.h PRE-CREATION
> src/plugins/voikko/voikkodebug.cpp PRE-CREATION
> src/plugins/voikko/voikkodict.h PRE-CREATION
> src/plugins/voikko/voikkodict.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/124282/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesse Jaara
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150707/d4a354b7/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list