Review Request 124213: Add standard shortcut for "new tab" action
Simon Persson
simon.persson at mykolab.com
Sat Jul 4 01:04:52 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124213/
-----------------------------------------------------------
(Updated July 4, 2015, 1:04 a.m.)
Review request for KDE Frameworks.
Changes
-------
Remove shortcut ctrl+shift+N, make ctrl+T the primary and only shortcut.
Repository: kconfig
Description
-------
QKeySequence already has AddTab as a standard shortcut, but it was missing in KStandardShortcut. Main problem with this is that users could not configure the shortcut globally. This is of course only a first step, applications would have to be updated to use this also.
Since QKeySequence uses Ctrl+Shift+N and Ctrl+T for this action when running on KDE, this patch just goes with that as the chosen default.
Also fixes documentation error for tabNext and tabPrev that I happened to notice.
Diffs (updated)
-----
src/gui/kstandardshortcut.h 5bb07fb
src/gui/kstandardshortcut.cpp 8400737
Diff: https://git.reviewboard.kde.org/r/124213/diff/
Testing
-------
Compiles, test suite ok.
Thanks,
Simon Persson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150704/fb9d5b3c/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list