Review Request 124222: kidletime: Introduce plugin infrastructure for platform specific parts

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124222/#review81991
-----------------------------------------------------------



src/kidletime.cpp (line 173)
<https://git.reviewboard.kde.org/r/124222/#comment56322>

    when you append stuff to an existing string, it's better to use QLatin1String (if the data is not unicode, of course). This is often faster and occupies less space in the executable. Also, you can duplicate the string at will and the compiler will be smart enough to deduplicate the data - it won't do that for lambdas and thus QStringLiteral.


- Milian Wolff


On July 2, 2015, 12:14 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124222/
> -----------------------------------------------------------
> 
> (Updated July 2, 2015, 12:14 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kidletime
> 
> 
> Description
> -------
> 
> Instead of having the platform specific implementations hard compiled
> in, they are split out into plugins which can get loaded at runtime
> depending on the platform we are in.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 23e5e2914e3a8991d14b664d80ac0d4b60545b40 
>   src/abstractsystempoller.h 00202d00b19fbbbd7443e07e411bdedecca230ee 
>   src/kidletime.cpp fc4ce77454db52d1bbaf9831c378f22548a237a7 
>   src/macpoller.h aab6a3acc16d5fb2b9a3156a142125a15d7e610f 
>   src/macpoller.cpp  
>   src/org.freedesktop.ScreenSaver.xml  
>   src/plugins/CMakeLists.txt PRE-CREATION 
>   src/plugins/osx/CMakeLists.txt PRE-CREATION 
>   src/plugins/osx/osx.json PRE-CREATION 
>   src/plugins/windows/CMakeLists.txt PRE-CREATION 
>   src/plugins/windows/windows.json PRE-CREATION 
>   src/plugins/xscreensaver/CMakeLists.txt PRE-CREATION 
>   src/plugins/xscreensaver/xcb.json PRE-CREATION 
>   src/plugins/xsync/CMakeLists.txt PRE-CREATION 
>   src/plugins/xsync/fixx11h.h PRE-CREATION 
>   src/plugins/xsync/xcb.json PRE-CREATION 
>   src/widgetbasedpoller.h fac0a724d32fb79a3c9b7829cba3b17f03bfff32 
>   src/windowspoller.h 502ed6dd6c6eaae1b35a14dce66812ebec30677e 
>   src/windowspoller.cpp  
>   src/xscreensaverbasedpoller.h 363ec521faa39e5b996c9e6767171f72005d11ca 
>   src/xscreensaverbasedpoller.cpp  
>   src/xsyncbasedpoller.h 8f67cbed38519e15cf5a96b5086da348ec8fabd5 
>   src/xsyncbasedpoller.cpp  
> 
> Diff: https://git.reviewboard.kde.org/r/124222/diff/
> 
> 
> Testing
> -------
> 
> Tried the example app on X11: it correctly loads the xsync plugin. If I modify it to be not available it correctly loads the xscreensaver plugin. In both cases the interaction is correct.
> 
> With --platform wayland no plugin gets loaded (as expected) and the functionality is pretty much broken.
> 
> Osx and Windows are obviously neither compile nor runtime tested. But I adjusted the code to my best knowledge.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150702/95a47150/attachment-0001.html>