Review Request 124226: Delete old highlighter

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124226/#review81973
-----------------------------------------------------------



src/widgets/ktextedit.cpp (line 662)
<https://git.reviewboard.kde.org/r/124226/#comment56298>

    no need for the if, you can just call `delete decorator->highlighter();`
    
    Also this is weird, deleting a returned attribute is not common, maybe KTextDecorator should delete it?


- Aleix Pol Gonzalez


On July 1, 2015, 9:02 p.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124226/
> -----------------------------------------------------------
> 
> (Updated July 1, 2015, 9:02 p.m.)
> 
> 
> Review request for KDE Frameworks and Laurent Montel.
> 
> 
> Repository: ktextwidgets
> 
> 
> Description
> -------
> 
> According to SpellCheckDecorator::setHighlighter's documentation, the old automatically created default highlighter must be manually deleted.
> 
> This fixes bug 343459 in Lokalize.
> 
> 
> Diffs
> -----
> 
>   src/widgets/ktextedit.cpp e4bd41d 
> 
> Diff: https://git.reviewboard.kde.org/r/124226/diff/
> 
> 
> Testing
> -------
> 
> Tested that it works in Lokalize. Also ran tests.
> 
> 
> Thanks,
> 
> Lasse Liehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150701/d3b174df/attachment-0001.html>