Review Request 124186: [runtime] Install headers and library for the private part

Aleix Pol Gonzalez aleixpol at kde.org
Wed Jul 1 12:53:35 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124186/#review81945
-----------------------------------------------------------

Ship it!



src/runtime/CMakeLists.txt (line 26)
<https://git.reviewboard.kde.org/r/124186/#comment56283>

    No need to call target_include_directories twice.


Makes sense to me, I wonder whether we can make it actual public API, I guess we'll see if it's needed in the future anyway.

- Aleix Pol Gonzalez


On June 26, 2015, 1:51 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124186/
> -----------------------------------------------------------
> 
> (Updated June 26, 2015, 1:51 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> We need to make the library and plugin interface available to support
> more platforms. On a Plasma Wayland session it's required that KWin
> becomes KGlobalAccel. KWin is the only process which can filter key
> events and for security reasons KWin will not delegate them to other
> applications.
> 
> This means KWin needs to create KGlobalAccelD before KWin or any other
> process tries to register a global shortcuts triggering kglobalaccel5
> to be started.
> 
> In addition KWin needs to provide it's own plugin which it can interact
> with.
> 
> 
> Diffs
> -----
> 
>   src/runtime/CMakeLists.txt 248762f98a6d5b24d4298976bdd1b5a1b4cf1a2c 
> 
> Diff: https://git.reviewboard.kde.org/r/124186/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150701/142a294b/attachment.html>


More information about the Kde-frameworks-devel mailing list